feat: deploy using version numbers for binaries #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacderida
force-pushed
the
deploy-versions
branch
from
8a4ae33
to
8ff51d1
Compare
Optionally supply version numbers, which will deploy the binaries built during the release process. We still need to build the faucet binary because that's not a released artifact at the moment. When the version number arguments are used, we skip building the `safenode` and `safe` binaries, which does shave a decent amount of time off the overall process. The other significant difference is that we pull the version binaries from the Github release rather than S3, so we had to introduce another mechanism for downloading those. At the moment the release process does not include uploading the versioned binaries to S3. Only the 'latest' version goes up there.
jacderida
force-pushed
the
deploy-versions
branch
from
8ff51d1
to
2c3e748
Compare
joshuef
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optionally supply version numbers, which will deploy the binaries built during the release process. We still need to build the faucet binary because that's not a released artifact at the moment.
When the version number arguments are used, we skip building the
safenodeandsafebinaries, which does shave a decent amount of time off the overall process.The other significant difference is that we pull the version binaries from the Github release rather than S3, so we had to introduce another mechanism for downloading those. At the moment the release process does not include uploading the versioned binaries to S3. Only the 'latest' version goes up there.