feat: provide deploy command
#2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `init` command is subsumed as a new `deploy` command because there's no real reason to have these separately; however, all the functionality from the `init` function in the `TestnetDeploy` struct is still retained. At this point, only the Terraform run is being performed. The Ansible run is still to follow.
This command will run a `terraform destroy`, delete the Terraform workspace, and clear out the generated Ansible inventory files. It will later be extended for AWS to clear out the created keypair. This commit also changes the library code in the crate to make use of the `Error` type defined in the crate rather than using `eyre` for generic errors. In doing so, we introduced a few specific errors for failures in the deployment process.
jacderida
force-pushed
the
terraform-run
branch
5 times, most recently
from
821d044
to
4b4f841
Compare
The licensing verification tool was switched on the in the merge workflow to assist in providing the relevant details. * Provided LICENSE file with BSD-3-Clause license * Provided copyright notices on source files * Updated the README to include reference to the license * Updated the Cargo.toml to include reference to the license
jacderida
force-pushed
the
terraform-run
branch
from
4b4f841
to
5d9b812
Compare
jacderida
changed the title
deploy commanddeploy command
| name: &str, | ||
| node_count: u16, | ||
| repo_owner: Option<String>, | ||
| branch: Option<String>, |
There was a problem hiding this comment.
I assume branch will be implemented/used in the follow up PR.
There was a problem hiding this comment.
Yeah, branch and repo owner are used by Ansible to build the custom branch. They aren't used by Terraform, other than to determine whether to create a build VM, which has a much higher specification than node VMs.
RolandSherwin
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7639f2e feat: provide
deploycommandThe
initcommand is subsumed as a newdeploycommand because there's no real reason to havethese separately; however, all the functionality from the
initfunction in theTestnetDeploystruct is still retained.
At this point, only the Terraform run is being performed. The Ansible run is still to follow.
02513e8 feat: provide
cleancommandThis command will run a
terraform destroy, delete the Terraform workspace, and clear out thegenerated Ansible inventory files.
It will later be extended for AWS to clear out the created keypair.
This commit also changes the library code in the crate to make use of the
Errortype defined inthe crate rather than using
eyrefor generic errors. In doing so, we introduced a few specificerrors for failures in the deployment process.
5d9b812 chore: provide licensing information
The licensing verification tool was switched on the in the merge workflow to assist in providing the
relevant details.