Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(context): Add more context menus. #713

Merged
merged 2 commits into from May 1, 2019
Merged

feat(context): Add more context menus. #713

merged 2 commits into from May 1, 2019

Conversation

joshuef
Copy link
Collaborator

@joshuef joshuef commented Apr 30, 2019 •
edited

Fixes #597

@joshuef joshuef added the to review ready for review label Apr 30, 2019
bochaco
bochaco reviewed Apr 30, 2019
View reviewed changes
Copy link
Member

@bochaco bochaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested in my linux on the authenticator page, and Ctrl+R refreshes the page, also Ctrl+[ / ] work going back/forth, but none of F5, Ctrl+F5, or Ctrl+Shift+R refreshees the page for me.

@joshuef
Copy link
Collaborator Author

joshuef commented May 1, 2019

I'd referenced the wrong issue there. Commit message update, and the real target is #597

bochaco
bochaco approved these changes May 1, 2019
View reviewed changes
Copy link
Member

@bochaco bochaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested the context menu options and they all work except for the select all, which didn't select the text from the authenticator page. I merging this anyway and perhaps you can treat that issue separately @joshuef

@bochaco bochaco merged commit 87741c5 into maidsafe:dev May 1, 2019
@joshuef joshuef deleted the FeatContextMenu branch September 6, 2019 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bochaco bochaco bochaco approved these changes

Assignees
No one assigned
Labels
to review ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Right click for navigation options (back / forward / reload)
2 participants
@joshuef @bochaco