This repository has been archived by the owner on Jun 25, 2021. It is now read-only.
feat: use thiserror for errors #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bochaco
reviewed
Dec 28, 2020
src/errors.rs
Outdated
| pub enum Error { | ||
| /// Access is denied for a given requester | ||
| /// Access denied for supplied PublicKey | ||
| #[error("Access Denied")] | ||
| AccessDenied, |
There was a problem hiding this comment.
Don't we want to provide the pk here so the consumer knows which pk was being used when the error was thrown? I know this is probably out of scope of this PR, but just thinking the direction we should take these errors to and start working on some consistency.
src/messaging/mod.rs
Outdated
| @@ -640,7 +640,7 @@ mod tests { | |||
| } | |||
|
|
|||
| #[test] | |||
| fn try_from() -> Result<()> { | |||
| fn try_from() -> anyhow::Result<()> { | |||
There was a problem hiding this comment.
Perhaps simply use anyhow::{Result, anyhow} for the whole test module?
There was a problem hiding this comment.
I did try that and things got wiiild w/ compiler errors. I'll double check that's not sorted now though
There was a problem hiding this comment.
that wildness is only in the seq file. the rest ill update
bochaco
approved these changes
Dec 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.