Skip to content

Commit

Permalink
fix: address CR comments - fix naming and spelling
Browse files Browse the repository at this point in the history
  • Loading branch information
davidrusu committed Aug 17, 2021
1 parent 3ea472e commit e796cfe
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion examples/mint-repl/mint-repl.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1127,7 +1127,7 @@ fn reissue_exec(
})
.collect();

// sort outputs by output_number
// sort outputs by name
output_dbcs.sort_by_key(|d| d.name());

// for each output, construct DbcUnblinded and display
Expand Down
2 changes: 1 addition & 1 deletion src/builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use curve25519_dalek_ng::scalar::Scalar;

use crate::{AmountSecrets, Dbc, DbcContent, ReissueTransaction, Result};

///! Unblinded data for creating to sn_dbc::DbcContent
///! Unblinded data for creating sn_dbc::DbcContent
pub struct Output {
pub amount: u64,
pub owner: blsttc::PublicKey,
Expand Down
8 changes: 4 additions & 4 deletions src/mint.rs
Original file line number Diff line number Diff line change
Expand Up @@ -546,12 +546,12 @@ mod tests {
};
let gen_dbc_name = genesis_dbc.name();

let genesis_secret_amounts =
let genesis_amount_secrets =
DbcHelper::decrypt_amount_secrets(&genesis_owner, &genesis_dbc.content)?;

let output_owner = crate::bls_dkg_id();
let (reissue_tx, _output_owners) = crate::TransactionBuilder::default()
.add_input(genesis_dbc.clone(), genesis_secret_amounts.clone())
.add_input(genesis_dbc.clone(), genesis_amount_secrets.clone())
.add_output(crate::Output {
amount: 1000,
owner: output_owner.public_key_set.public_key(),
Expand All @@ -575,7 +575,7 @@ mod tests {
let (t, s) = genesis_node.reissue(reissue_req, BTreeSet::from_iter([gen_dbc_name]))?;

let (double_spend_reissue_tx, _output_owners) = crate::TransactionBuilder::default()
.add_input(genesis_dbc, genesis_secret_amounts)
.add_input(genesis_dbc, genesis_amount_secrets)
.add_output(crate::Output {
amount: 1000,
owner: output_owner.public_key_set.public_key(),
Expand Down Expand Up @@ -1165,7 +1165,7 @@ mod tests {

// Next: attempt reissuing the output DBC:
// a) with provided secret amount (in band for recipient). (should fail)
// b) with true committed amount (out of band for recipient). (should succeeed)
// b) with true committed amount (out of band for recipient). (should succeed)

let input_dbc = output_dbc;
let input_secrets = DbcHelper::decrypt_amount_secrets(&outputs_owner, &input_dbc.content)?;
Expand Down

0 comments on commit e796cfe

Please sign in to comment.