Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression in bench_reissue_100_to_1. reissue fails with error FailedUnblinding #79

Closed
dan-da opened this issue Aug 18, 2021 · 1 comment · Fixed by #77
Closed

regression in bench_reissue_100_to_1. reissue fails with error FailedUnblinding #79

dan-da opened this issue Aug 18, 2021 · 1 comment · Fixed by #77
Assignees

Comments

@dan-da
Copy link
Contributor

dan-da commented Aug 18, 2021

With latest sn_dbc (635bf14 release 2.4.0) I get the following error when running cargo bench:

$ cargo bench merge
...
Benchmarking reissue merge 100 to 1: Warming up for 3.0000 sthread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: FailedUnblinding', benches/reissue.rs:227:18
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

error: bench failed

I used git bisect to trace this back to the commit where it first occurred, which is:

commit 980c55f7a9e680d3702a7a02e6e908be5e6cf9f2
Author: David Rusu <drusu@Davids-MacBook-Air.local>
Date:   Fri Aug 13 13:51:14 2021 -0600

    chore: from_iter(vec![..]) to from_iter([..])

M       benches/reissue.rs
M       examples/mint-repl/mint-repl.rs
M       src/dbc.rs
M       src/lib.rs
M       src/mint.rs

I do not immediately see what the problem is, else I would have just fixed it.

@davidrusu
Copy link
Contributor

should be fixed in #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants