This repository has been archived by the owner on Jun 25, 2021. It is now read-only.
Anti entropy #105
Merged
Anti entropy #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /// Type of message. | ||
| /// Note this is part of this crate's public API but this enum is | ||
| /// never serialised or even part of the message that is sent over the wire. | ||
| #[derive(PartialEq, Debug)] | ||
| #[derive(PartialEq, Debug, Clone)] |
There was a problem hiding this comment.
We need to be careful deriving Clone on types that can be very large. IMO it's best if we avoid this as much as possible so we are naturally careful with .clone().
| pub fn src_section_pk(&self) -> Option<PublicKey> { | ||
| self.src_section_pk | ||
| } | ||
|
|
||
| // Parses the provided bytes to deserialize a WireMsgHeader, | ||
| // returning the created WireMsgHeader, as well as the remaining bytes which | ||
| // correspond to the message payload. The caller shall then take care of | ||
| // deserializing the payload using the information provided in the WireMsgHeader. | ||
| pub fn from(mut bytes: Bytes) -> Result<(Self, Bytes)> { |
There was a problem hiding this comment.
I think it's best to keep this function definition consistent with the From trait and rename this.
There was a problem hiding this comment.
This could probably go into it's own PR. Maybe there's a bunch of things like this that can be done all in one go.
oetyng
force-pushed
the
anti-entropy
branch
5 times, most recently
from
2113366
to
2c42284
Compare
This reverts commit 158e3a3.
- Relocating NodeCmd messages into the node module. - Temporarily have a variant length wire message header, to accomodate the src section public key as optional for some of the NodeCmd messages.
…eserialise NodeCmdMessages
- Also removes some repitition.
oetyng
force-pushed
the
anti-entropy
branch
2 times, most recently
from
8a8eb69
to
4eac2f1
Compare
- Outdated since section wallets are no longer used.
oetyng
approved these changes
May 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.