This repository has been archived by the owner on Jun 25, 2021. It is now read-only.
refactor(join): re-organising all messages related to node joining flow #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bochaco
force-pushed
the
feat-join-redirect-msgs
branch
10 times, most recently
from
d6bfa97
to
7d85972
Compare
bochaco
force-pushed
the
feat-join-redirect-msgs
branch
3 times, most recently
from
8d3b971
to
fb5e63c
Compare
BREAKING CHANGE: new Join messages are not backward compatible.
bochaco
force-pushed
the
feat-join-redirect-msgs
branch
from
fb5e63c
to
687345d
Compare
Yoga07
reviewed
Jun 8, 2021
| @@ -22,10 +22,7 @@ use xor_name::{Prefix, XorName}; | |||
| #[derive(Debug, Serialize, Deserialize, PartialEq, Clone)] | |||
| pub enum Message { | |||
| /// Message to request information about the section that matches the given name. | |||
| GetSectionQuery { | |||
| public_key: PublicKey, | |||
| is_node: bool, | |||
There was a problem hiding this comment.
IIRC this was recently added by @lionel1704 for a fix on bootstrapping of adults.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.