fix: proper differentiate local close and peer un-reachable

maidsafe · Jun 6, 2021 · 655d8a2 · 655d8a2
1 parent 4377a24
commit 655d8a2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/routing/comm.rs b/src/routing/comm.rs
@@ -217,11 +217,13 @@ impl Comm {
                 .send_to(&recipient.1, msg_bytes)
                 .await
                 .map_err(|err| match err {
-                    qp2p::Error::Connection(qp2p::ConnectionError::LocallyClosed)
-                    | qp2p::Error::Connection(qp2p::ConnectionError::TimedOut) => {
+                    qp2p::Error::Connection(qp2p::ConnectionError::LocallyClosed) => {
+                        Error::ConnectionClosed
+                    }
+                    _ => {
+                        trace!("during sending, received error {:?}", err);
                         Error::AddressNotReachable { err }
                     }
-                    _ => Error::ConnectionClosed,
                 });
 
             (result, recipient.1)

diff --git a/tests/drop.rs b/tests/drop.rs
@@ -15,7 +15,6 @@ use sn_messaging::{Aggregation, DstLocation, Itinerary, SrcLocation};
 use sn_routing::{Event, NodeElderChange};
 
 #[tokio::test]
-#[ignore]
 async fn test_node_drop() -> Result<()> {
     // NOTE: create at least 4 nodes, so when one is dropped the remaining ones still form a
     // supermajority and the `Offline` proposals reach agreement.