This repository has been archived by the owner on Jun 25, 2021. It is now read-only.
chore(err): remove qp2p error as a public type #2466
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+28
to
+31
| #[error("The config is invalid")] | ||
| InvalidConfig, | ||
| #[error("Cannot connect to the endpoint")] | ||
| CannotConnectEndpoint, |
There was a problem hiding this comment.
Perhaps we could add some context to these errors to help identify the cause using:
.map_err(|err| ErrorVariant(err.to_string()))
There was a problem hiding this comment.
yeh will do that as part of the next step as I need to do it to the other variants as well
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes qp2p errors as being exported and converts them into custom errors