This repository has been archived by the owner on Jun 25, 2021. It is now read-only.
refactor(comm): change return of send to reflect the logic of delivery_group_size
#2476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dylan-DPC-zz
force-pushed
the
refactor/send_status
branch
from
07765f4
to
d0b7ac6
Compare
dirvine
previously approved these changes
May 3, 2021
maqi
reviewed
May 3, 2021
| @@ -1108,7 +1108,7 @@ impl Core { | |||
| }; | |||
| if recipients.is_empty() { | |||
| trace!("Cannot route user message, recipient list empty: {:?}", msg); | |||
| return Err(Error::CannotRoute); | |||
| return Err(Error::EmptyRecipientList); | |||
There was a problem hiding this comment.
I do think the previous CannotRoute error back is more accurate?
There was a problem hiding this comment.
I felt EmpyRecipientList gives a more clearer image of the error compared to CannotRoute
Dylan-DPC-zz
force-pushed
the
refactor/send_status
branch
from
f7d7ee7
to
a95dbba
Compare
Dylan-DPC-zz
force-pushed
the
refactor/send_status
branch
from
a95dbba
to
27a48a5
Compare
maqi
approved these changes
May 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change return of
sendto reflect the logic of delivery_group_sizedelivery_group_sizeor notBREAKING CHANGE: return type ofComm::sendis nowResult<SendStatus>