Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate pub const - trivial #2012

Closed
davidpbrown opened this issue Jan 20, 2023 · 0 comments · Fixed by #2110
Closed

Duplicate pub const - trivial #2012

davidpbrown opened this issue Jan 20, 2023 · 0 comments · Fixed by #2110

Comments

@davidpbrown
Copy link
Contributor

Likely these should not be declared twice..

pub const DEFAULT_XORURL_BASE ./sn_api/src/safeurl/mod.rs
pub const DEFAULT_XORURL_BASE ./sn_api/src/app/consts.rs

pub const NRS_MAP_TYPE_TAG ./sn_api/src/safeurl/mod.rs
pub const NRS_MAP_TYPE_TAG ./sn_api/src/app/nrs/mod.rs
@b-zee b-zee mentioned this issue Feb 16, 2023
Merged
bors bot added a commit that referenced this issue Feb 16, 2023
@bors @b-zee
Merge #2110
fa19922 
2110: refactor(api): use single const declaration r=oetyng a=b-zee

Closes #2012

<!--
Thanks for contributing to the project! We recommend you check out our "Guide to contributing" page if you haven't already: https://github.com/maidsafe/QA/blob/master/CONTRIBUTING.md

Write your comment below this line: -->


Co-authored-by: Benno Zeeman <bzeeman@live.nl>
@bors bors bot closed this as completed in 05a2d1a Feb 16, 2023
@reviewpad reviewpad bot mentioned this issue Apr 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(api): use single const declaration
1 participant
@davidpbrown