-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor update architecture to "plug in" #147
Conversation
user_count = 0 | ||
for account in accounts: | ||
#don't process admin users | ||
if account.type == "administrator": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we had plans to keep "inactive" GDEs in the Account list, but I think those shouldn't be included in the update task either, so maybe make the check:
if account.type != "active":
Except for the two minor non-critical inline-comments I made this looks great! 👍 Thanks! |
user_count = 0 | ||
for account in accounts: | ||
#don't process admin users | ||
if account.type == "administrator": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing as above:
if account.type != "active":
#54 can be closed |
Sounds/looks good to me, feel free to merge and close whenever you deploy this into production :) |
refactor update architecture to "plug in"
Disabling writes, taking a backup and uploading the code, reenable writes -> All Done |
The implementation is different in that we only merge AP is they are actual shares from another post, if they are not we will create a new AR and leave it to the GDE to decide how and why he merges AR's and their associated AP's. In order to do this, I process the new activities from oldest to newest.
The implementation is pretty much the same as previously. In particular we continue to ignore the fact that a #gde tag is removed from a gplus post, we consider currently that it has to be deleted in the front end, to be discussed at the summit.
@Scarygami thanks for having a good look at this :)