feature: Add configuration option for soft breaks #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows you to configure soft breaks to be rendered as "hard breaks" by passing in the whitespace you want to use in the options.
|
Hi @espenhogbakk, thanks for the pull request. The configuration option for soft breaks looks fine to me. But please do not commit the dist folder to git. Can you update the pull request? Cheers, |
I @maiers I will do, I totally forgot about that and I agree this should not be in this PR, but I would urge you to reconsider not having the dist folder in the repo. I do understand why you don't want to, but it does prevent one from installing this library directly from GitHub without relying on released packages on npm. Which is why I changed it so I could install the code in my PR before this was merged in and released. |
|
Closing because of inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to configure soft breaks to be rendered as "hard breaks" by passing in the whitespace you want to use in the options.