Convert kebob-case to snake-case in attribute names #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First pass at option to convert hyphens to underscores in hash keys.
|
That seems to be a useful addition, but I am wondering, if we should better call it kebab-case? That is, we should rename the kabobtosnakecase option to kebabtosnakecase and we should rename all variables and constants, too. |
|
I agree. I can make that change and re-submit. |
|
That'd be great! |
|
Ready for your review. |
|
Thank you very much! It looks good and I've adjusted a few other things in the meantime. Did you create any tests? If not, I'll write some. |
|
No, sorry, no tests. It is working in production here, if that's any consolation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We made this change to meet a requirement in an application. I feel that it could be useful for others who are ingesting XML that's out of their control.