Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert architecture support in preflight.sh, to keep i686 #885

Closed
guyzmo opened this issue Jul 6, 2016 · 6 comments
Closed

Revert architecture support in preflight.sh, to keep i686 #885

guyzmo opened this issue Jul 6, 2016 · 6 comments

Comments

@guyzmo
Copy link
Contributor

guyzmo commented Jul 6, 2016

Since 0.15, the preflight.sh script had a new condition forcing the host architecture to be x86-64, whereas all applications required for MIAB run as smoothly in 32bits as they do in 64bits. The only reason we'd need to run as 64bits is if the machine has a lot of RAM available.

I suggest to change the check so it becomes:

if [ "$ARCHITECTURE" != "x86_64" ] && [ "$ARCHITECTURE" != "i686" ]; then

within preflight.sh. I'll make a PR when I have a couple of minutes to spend on that.

@yodax
Copy link
Contributor

yodax commented Jul 6, 2016

Never crossed my mind! Sorry about that. Let me know if you don't get around to the PR since it was my PR that caused this.

@guyzmo
Copy link
Contributor Author

guyzmo commented Jul 6, 2016

well, I already hacked it in my prod instance, and the upgrade went fine, I just need to write it in a patch in my dev instance to be able to push it ☺

@yodax
Copy link
Contributor

yodax commented Jul 17, 2016

I created a pull request for it.

@guyzmo
Copy link
Contributor Author

guyzmo commented Jul 20, 2016

Thank you a lot, I did not do it because I have been away from keyboards and wifi and 3G for a week and I just came back ☺

@yodax
Copy link
Contributor

yodax commented Jul 20, 2016

No problem!

JoshData pushed a commit that referenced this issue Jul 29, 2016
This is checked during preflight. See #885 (#889)
@JoshData
Copy link
Member

Closed via #889.

emmanuelvargas pushed a commit to emmanuelvargas/power-mailinabox that referenced this issue Jul 12, 2021
This is checked during preflight. See mail-in-a-box/mailinabox#885 (#889)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants