Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take spamhaus return codes into account in status check and postfix config #2332

Merged
merged 3 commits into from Mar 10, 2024

Conversation

kiekerjan
Copy link
Contributor

@kiekerjan kiekerjan commented Nov 24, 2023

Spamhaus defines a number of return codes in its blocklist lookups, e.g. 127.0.0.1 or 127.255.255.252 These are described here Not all these codes indicate that an ip or domain is really on the Spamhaus blacklist. It could also be that an open DNS server is used, or too much queries are made from the same DNS server. This is usually caused by not using the DNS resolver built-in in the MiaB installation.

The issue here is that the status check and postfix will trigger a false positive in case that Spamhaus returns an error code (one of the 127.255.255.* codes). Thus, Mail-in-a-Box incorrectly describes these as a hit on a Spamhaus blocklist. (e.g. "This domain is listed in the Spamhaus domain blocklist...") and postfix will also incorrectly reject a mail as spam.

This commit:

  • Takes the defined error codes into account on the system status checks page and provides a more correct description.
  • Configures postfix to trigger only on real spam reports (as adviced by spamhaus here)

@kiekerjan kiekerjan changed the title Take spamhaus return codes into account in the status check Take spamhaus return codes into account in status check and postfix config Nov 25, 2023
Copy link

@ericmann ericmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These will fix the problem and help avoid losing these particular customizations when upgrading down the road. I'd love to see them merged in ...

@JoshData JoshData merged commit 0b1d923 into mail-in-a-box:main Mar 10, 2024
@JoshData
Copy link
Member

I force-pushed to resolve a conflict and then also modified some of the status message text to be more similar to existing messages.

@JoshData
Copy link
Member

And thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants