Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement public key finder using datastore #479

Closed
5 tasks
robdefeo opened this issue Dec 31, 2019 · 0 comments · Fixed by #536
Closed
5 tasks

implement public key finder using datastore #479

robdefeo opened this issue Dec 31, 2019 · 0 comments · Fixed by #536
Labels
cmd/pkf enhancement New feature or request
Projects

Comments

@robdefeo
Copy link
Member

Is your feature request related to a problem? Please describe.
cmd/pkf will return a public key based on an address, it should use the public_key.go in cmd/internal/datastore ref #478

Describe the solution you'd like

  • implement the method as defined in create GET public key method definition #477
  • use the datastore.PublicKey to search for the public key
  • use datastore.PublicKey interface as parameter to handler creation
  • return status 200 for not found public key, see cmd/mailchain/internal/http/handlers/resolve_name.go
  • create unit tests
@robdefeo robdefeo added enhancement New feature or request cmd/pkf labels Dec 31, 2019
@robdefeo robdefeo added this to To do in cmd/pkf Dec 31, 2019
cmd/pkf automation moved this from To do to Done Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/pkf enhancement New feature or request
Projects
cmd/pkf
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant