Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create GET public key method definition #477

Closed
4 tasks
robdefeo opened this issue Dec 31, 2019 · 0 comments · Fixed by #536
Closed
4 tasks

create GET public key method definition #477

robdefeo opened this issue Dec 31, 2019 · 0 comments · Fixed by #536
Labels
cmd/pkf devex Developer Experience enhancement New feature or request
Projects

Comments

@robdefeo
Copy link
Member

Is your feature request related to a problem? Please describe.
The public key finder needs to expose a GET method to query the address and return a public key.

Describe the solution you'd like

  • create pubkey.go in cmd/pkf/internal/http/handlers
  • create skeleton methods based on cmd/mailchain/internal/http/handlers/pubkey.go
  • include the swagger comments
  • NOTE: implementation of the handler is not required for this issue.

Additional context
See cmd/mailchain/internal/http/handlers/pubkey.go for implementation in cmd/mailchain it is ok to copy from here to start with. Later there will be some drift as additional features are added.

@robdefeo robdefeo added enhancement New feature or request devex Developer Experience cmd/pkf labels Dec 31, 2019
@robdefeo robdefeo added this to To do in cmd/pkf Dec 31, 2019
developerfred added a commit to developerfred/mailchain that referenced this issue Feb 5, 2020
cmd/pkf automation moved this from To do to Done Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/pkf devex Developer Experience enhancement New feature or request
Projects
cmd/pkf
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant