feat: add network ids to /protocol endpoint. #401

pascaloseko · 2019-11-18T13:13:10Z

Added network IDs to both ethereum and substrates.
Also modified tests to the changes made.

cmd/mailchain/internal/settings/root.go

cmd/mailchain/internal/http/handlers/protocols.go

internal/protocols/substrate/address.go

internal/protocols/substrate/address_test.go

internal/protocols/substrate/address.go

cmd/mailchain/internal/settings/root.go

cmd/mailchain/internal/http/handlers/protocols.go

robdefeo

Thanks @pascaloseko this is great. Will merge 😄

robdefeo · 2019-11-26T22:46:50Z

Thanks @pascaloseko for your first contribution 😄 it fixes #281

golangcibot reviewed Nov 18, 2019

View reviewed changes

cmd/mailchain/internal/settings/root.go Outdated Show resolved Hide resolved

cmd/mailchain/internal/http/handlers/protocols.go Outdated Show resolved Hide resolved

pascaloseko force-pushed the Issue/281 branch from 5048d72 to 2d90d0a Compare November 18, 2019 19:58

golangcibot reviewed Nov 18, 2019

View reviewed changes

cmd/mailchain/internal/http/handlers/protocols.go Outdated Show resolved Hide resolved

golangcibot reviewed Nov 19, 2019

View reviewed changes

cmd/mailchain/internal/http/handlers/protocols.go Outdated Show resolved Hide resolved

golangcibot reviewed Nov 19, 2019

View reviewed changes

cmd/mailchain/internal/http/handlers/protocols.go Outdated Show resolved Hide resolved

golangcibot reviewed Nov 19, 2019

View reviewed changes

cmd/mailchain/internal/http/handlers/protocols.go Outdated Show resolved Hide resolved

robdefeo requested changes Nov 21, 2019

View reviewed changes

pascaloseko added 7 commits November 23, 2019 11:50

feat: add network ids to /protocol endpoint.

33a02d5

fix: test fail on yaml bulds

83823a7

resolve expressions being cuddled with blocks.

020e924

resoleve format by gofmt

86b19eb

changed sructure of slice from block to line.

e6a64af

format root.go

f0df1d8

resolved comments

9881914

pascaloseko force-pushed the Issue/281 branch from f959baf to 9881914 Compare November 24, 2019 08:22

improve coverage

9cf047b

golangcibot reviewed Nov 24, 2019

View reviewed changes

cmd/mailchain/internal/http/handlers/protocols.go Outdated Show resolved Hide resolved

cmd/mailchain/internal/http/handlers/protocols.go Outdated Show resolved Hide resolved

pascaloseko and others added 2 commits November 24, 2019 11:37

changed switch to if statement

53d9703

Merge branch 'master' into Issue/281

35090de

robdefeo approved these changes Nov 26, 2019

View reviewed changes

robdefeo merged commit 0f77673 into mailchain:master Nov 26, 2019

robdefeo mentioned this pull request Nov 26, 2019

Add network ids to /protocols endpoint #281

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add network ids to /protocol endpoint. #401

feat: add network ids to /protocol endpoint. #401

pascaloseko commented Nov 18, 2019

robdefeo left a comment

robdefeo commented Nov 26, 2019

feat: add network ids to /protocol endpoint. #401

feat: add network ids to /protocol endpoint. #401

Conversation

pascaloseko commented Nov 18, 2019

robdefeo left a comment

Choose a reason for hiding this comment

robdefeo commented Nov 26, 2019