Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: SyncStore.GetBlockNumber #468

Merged
merged 3 commits into from
Dec 23, 2019
Merged

test: SyncStore.GetBlockNumber #468

merged 3 commits into from
Dec 23, 2019

Conversation

ramkumarvenkat
Copy link
Contributor

@ramkumarvenkat ramkumarvenkat commented Dec 23, 2019 •
edited

Fixes #449

robdefeo
robdefeo approved these changes Dec 23, 2019
View reviewed changes
Copy link
Member

@robdefeo robdefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @ramkumarvenkat thanks. Good to merge.

cmd/indexer/internal/datastore/pq/sync.go
@@ -47,7 +47,7 @@ func (s SyncStore) GetBlockNumber(ctx context.Context, protocol, network string)
}

state := sync{}
if err := s.db.Get(&state, sql, args); err != nil {
if err := s.db.Get(&state, sql, args...); err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot! Thanks for that.

@robdefeo robdefeo merged commit 785dc1c into mailchain:master Dec 23, 2019
@ramkumarvenkat ramkumarvenkat deleted the issue/449 branch December 24, 2019 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robdefeo robdefeo robdefeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unit tests for GetBlockNumber
2 participants
@ramkumarvenkat @robdefeo