feat: return public key type #533
Conversation
- Adds skeleton for sending substrate transactions functionality - Example code that actually can send a transaction on edgeware test network (see Test_SubstrateCallExample)
- Removes subkey dependency - Coarse grained verify usage for testing singer sing method
|
opened against incorrect branch |
| Xt types.Extrinsic | ||
| } | ||
|
|
||
| //func New(address string) (*SubstrateRPC, error) { |
There was a problem hiding this comment.
commentFormatting: put a space between // and comment text (from gocritic)
|
|
||
| func (e Signer) createSignature(signedData []byte) (*types.MultiSignature, error) { | ||
| sig := types.NewSignature(signedData) | ||
| switch e.privateKey.(type) { |
There was a problem hiding this comment.
type switch statements should only be cuddled with variables switched (from wsl)
| if err != nil { | ||
| return nil, err | ||
| } | ||
| era := opts.Era |
There was a problem hiding this comment.
assignments should only be cuddled with other assignments (from wsl)
| return nil, err | ||
| } | ||
| era := opts.Era | ||
| if !opts.Era.IsMortalEra { |
There was a problem hiding this comment.
only one cuddle assignment allowed before if statement (from wsl)
| if !opts.Era.IsMortalEra { | ||
| era = types.ExtrinsicEra{IsImmortalEra: true} | ||
| } | ||
| payload := types.ExtrinsicPayloadV3{ |
There was a problem hiding this comment.
assignments should only be cuddled with other assignments (from wsl)
| return nil, err | ||
| } | ||
| signedData, err := e.privateKey.Sign(data) | ||
| if err != nil { |
There was a problem hiding this comment.
only one cuddle assignment allowed before if statement (from wsl)
| return nil, err | ||
| } | ||
| signature, err := e.createSignature(signedData) | ||
| if err != nil { |
There was a problem hiding this comment.
only one cuddle assignment allowed before if statement (from wsl)
| ext := &opts.Extrinsic | ||
| ext.Signature = extSig | ||
| ext.Version |= types.ExtrinsicBitSigned | ||
| return ext, nil |
There was a problem hiding this comment.
return statements should not be cuddled if block has more than two lines (from wsl)
| if (blockHash == types.Hash{}) { | ||
| return s.api.RPC.State.GetMetadataLatest() | ||
| } | ||
| return s.api.RPC.State.GetMetadata(blockHash) |
There was a problem hiding this comment.
return statements should not be cuddled if block has more than two lines (from wsl)
| } | ||
|
|
||
| func (s SubstrateClient) SuggestGasPrice(ctx context.Context) (*big.Int, error) { | ||
| return big.NewInt(32000), nil |
There was a problem hiding this comment.
mnd: Magic number: 32000, in detected (from gomnd)
fixes #381