add test (#176)

update mailchain service
mailchain · Mar 28, 2020 · a504f48 · a504f48
1 parent 73dd51c
commit a504f48
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/app/services/mailchain/mailchain.service.spec.ts b/src/app/services/mailchain/mailchain.service.spec.ts
@@ -81,6 +81,14 @@ describe('MailchainService', () => {
 
       expect(response).toEqual(ethereumAccountAddress)
     });
+
+    it('should return a blank string if the Mailchain address is invalid', () => {
+      const mailchainAddress = "<0x@ropsten.ethereum>"
+
+      let response = mailchainService.parseAddressFromMailchain(mailchainAddress)
+
+      expect(response).toEqual('')
+    });
   })
 
   describe('dedupeMessagesByIds', () => {

diff --git a/src/app/services/mailchain/mailchain.service.ts b/src/app/services/mailchain/mailchain.service.ts
@@ -50,6 +50,8 @@ export class MailchainService {
     var regexMailAddr = new RegExp('<0x[0-9a-fA-Z]{40}[@].+>$');
     if (regexMailAddr.test(address)) {
       return address.substr(1, address.indexOf('@') - 1);
+    } else {
+      return ''
     }
   }