Skip to content
This repository has been archived by the owner on Apr 4, 2022. It is now read-only.

Handle nameservice enabled flags from Mailchain api #215

Closed
tboeckmann opened this issue Oct 10, 2020 · 0 comments
Closed

Handle nameservice enabled flags from Mailchain api #215

tboeckmann opened this issue Oct 10, 2020 · 0 comments
Assignees

Comments

@tboeckmann
Copy link
Contributor

Is your feature request related to a problem? Please describe.
In order to reduce nameservice lookup attempts for unsupported protocols, Mailchain introduced nameservice flags on the /protocols endpoint see mailchain#640:

[
    {
        "name": "string",
        "networks": [
            {
                "id": "string",
                "name": "string",
                "nameservice-address-enabled": true,
                "nameservice-domain-enabled": true
            }
        ]
    }
]

Describe the solution you'd like
Add support for this feature in the Mailchain inbox so lookups do not occur unnecessarily.

Describe alternatives you've considered
Requesting Mailchain backend to handle the logic- this could be done at a later stage, but the current proposed fix is sufficient

@tboeckmann tboeckmann self-assigned this Oct 10, 2020
tboeckmann added a commit that referenced this issue Oct 18, 2020
* Fix typo in error message

* update angular cli

* update protocols response

* add local-storage-nameservice service

* add getProtocolNetworkAttributes to be used for any attribute for a protocol network

* Add methods to inbox for nameservice settings

* handle observable and awaits for resolving names

* add more async calls to tests
add conditional logic for calling resolveName and resolveAddress

* fix test

* clear sessionStorage before each test

* fix tests

* temporary test fix (see #217)

* fix tests by adding protocols stub
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant