Skip to content
This repository has been archived by the owner on Apr 4, 2022. It is now read-only.

Add localStorage methods for currentProtocol #63

Closed
tboeckmann opened this issue Aug 13, 2019 · 0 comments
Closed

Add localStorage methods for currentProtocol #63

tboeckmann opened this issue Aug 13, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tboeckmann
Copy link
Member

tboeckmann commented Aug 13, 2019

Is your feature request related to a problem? Please describe.
The currentProtocol is hard coded for now in the inbox view.

public currentProtocol: string = "ethereum"

It should be a LocalStorageProtocolService.getCurrentProtocol() lookup to handle additional protocols going forwards.

The lookup should be added to:

  async ngOnInit(): Promise<void> {
    this.setFetchingMessagesState(true)

    try {
      this.currentAccount = await this.localStorageAccountService.getCurrentAccount()
      this.currentNetwork = this.localStorageServerService.getCurrentNetwork()
      // <<< Insert here
      this.getServerSettings()
    } catch (error) {
    ...
  }

Does this need to be async?

This is also used by the child view components, compose, message

@tboeckmann tboeckmann self-assigned this Aug 13, 2019
@tboeckmann tboeckmann removed their assignment Dec 1, 2019
@tboeckmann tboeckmann added enhancement New feature or request good first issue Good for newcomers labels Dec 1, 2019
developerfred added a commit to developerfred/mailchain-web that referenced this issue Dec 17, 2019
developerfred added a commit to developerfred/mailchain-web that referenced this issue Dec 17, 2019
developerfred added a commit to developerfred/mailchain-web that referenced this issue Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant