Skip to content
This repository has been archived by the owner on Apr 4, 2022. It is now read-only.

fix: change footer position style #104 #105

Merged
merged 4 commits into from
Nov 26, 2019

Conversation

developerfred
Copy link
Contributor

No description provided.

Copy link
Member

@tboeckmann tboeckmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for flagging this issue. I added some comments that I think would lead to a more consistent UX across different view scenarios.

Feel free to adjust if you agree.

src/app/app.component.scss Show resolved Hide resolved
	modified:   src/app/app.component.scss
@developerfred developerfred changed the title #104 change footer position style fix: change footer position style #104 Nov 18, 2019
@tboeckmann tboeckmann self-requested a review November 24, 2019 22:29
@developerfred
Copy link
Contributor Author

done

@tboeckmann
Copy link
Member

@developerfred There’s still an issue with position. Can you revert it to fixed?

I can then merge.

Thanks!

@tboeckmann tboeckmann merged commit 5bc5c25 into mailchain:master Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants