Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unit tests for GetBlockNumber #449

Closed
robdefeo opened this issue Dec 18, 2019 · 0 comments · Fixed by #468
Closed

unit tests for GetBlockNumber #449

robdefeo opened this issue Dec 18, 2019 · 0 comments · Fixed by #468
Labels
cmd/indexer devex Developer Experience enhancement New feature or request good first issue Good for newcomers tests
Projects
cmd/indexer

Comments

@robdefeo
Copy link
Member

Is your feature request related to a problem? Please describe.
GetBlockNumber is not tested

Describe the solution you'd like
Unit tests for GetBlockNumber in cmd/indexer/internal/datastore/pq/sync.go
@robdefeo robdefeo added enhancement New feature or request good first issue Good for newcomers devex Developer Experience cmd/indexer tests labels Dec 18, 2019
@ramkumarvenkat ramkumarvenkat mentioned this issue Dec 23, 2019
Merged
@robdefeo robdefeo added this to Done in cmd/indexer Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cmd/indexer devex Developer Experience enhancement New feature or request good first issue Good for newcomers tests
Projects
cmd/indexer
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: SyncStore.GetBlockNumber ramkumarvenkat/mailchain
1 participant
@robdefeo