Only add runtime files to npm package #170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://docs.npmjs.com/misc/developers#keeping-files-out-of-your-package Fixes mailcheck#169 It's generally good practice IMO to keep only the things consumers need to use your lib in npm. In this case, your specs folder references a vulnerable version of jquery which is fine since it's not used at runtime, but it causes false positives for vulnerability scanners like retireJS. Keeping your npm bundle slim is also good for helping fight node_modules cruft and slow installs.
sandipsubedi
approved these changes
May 2, 2019
|
Hey @SethDavenport, fully agree with you, unfortunately this library is no longer maintained. I rewrote it entirely and update it for 2022 and onward: https://github.com/ZooTools/email-spell-checker
Link: https://github.com/ZooTools/email-spell-checker Come check it out and give it a ⭐️ for the effort. |
|
OK, thanks, I'll check it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.npmjs.com/misc/developers#keeping-files-out-of-your-package
Fixes #169
It's generally good practice IMO to keep only the things consumers need to use your lib in npm. In this case, your specs folder references a vulnerable version of jquery, which is fine since it's not used at runtime, but it causes false positives for vulnerability scanners like retireJS.
Keeping your npm bundle slim is also good for helping fight node_modules cruft and slow installs.