Add simplified Chinese language translations #3784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wew nice! |
|
Oh, I missed that. |
Added. |
|
I think it's ready to be reviewed. |
|
LGTM @andryyy |
|
Very cool. Thank you! |
|
It's starting and does not crash for me |
I don't think it would be a problem because |
|
Let me check that too and then merge it. :) |
|
Thank you!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally, we use language code 'zh-cn' to represent simplified Chinese, 'zh-tw' in the case of traditional Chinese.
Due to the limitation of https://github.com/usrz/bootstrap-languages used by mailcow UI, there is only code 'zh' avaliable for Chinese. That's why I use 'zh' instead.
Maybe we should switch from bootstrap-languages in future so that we can add support for traditional Chinese.