Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web] apple config app passwords enhancements + translations #4342

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

feldsam
Copy link
Member

@feldsam feldsam commented Nov 26, 2021

Signed-off-by: Kristian Feldsam feldsam@gmail.com

Hi @mkuron, I changed a few things in your work, please check.

  • user.php - keep template and data definition in each other
  • *.twig - use of format instead of replace and show <br> only on lg screens

Desktop:
Screenshot 2023-09-04 at 8 42 49

Mobile:
Screenshot 2023-09-04 at 8 43 06

@DerLinkman DerLinkman deleted the branch mailcow:staging January 21, 2022 13:54
@DerLinkman DerLinkman closed this Jan 21, 2022
@waja
Copy link
Contributor

waja commented Jan 21, 2022

ping

@DerLinkman DerLinkman reopened this Jan 21, 2022
@DerLinkman
Copy link
Member

Yeah sorry for the closing, wasn't my intention.

@feldsam
Copy link
Member Author

feldsam commented Mar 14, 2022

@andryyy what about this?

@feldsam feldsam force-pushed the staging branch 2 times, most recently from 2aead31 to 880a68d Compare March 22, 2022 13:50
@DerLinkman DerLinkman deleted the branch mailcow:staging May 5, 2022 15:30
@DerLinkman DerLinkman closed this May 5, 2022
@DerLinkman DerLinkman reopened this May 5, 2022
@milkmaker
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@milkmaker milkmaker added the stale Please update the issue with current status, unclear if it's still open/needed. label Jul 12, 2022
@milkmaker milkmaker closed this Jul 20, 2022
@feldsam feldsam reopened this Jul 20, 2022
@milkmaker milkmaker closed this Jul 28, 2022
@mkuron mkuron reopened this Jul 28, 2022
@mkuron mkuron added enhancement and removed stale Please update the issue with current status, unclear if it's still open/needed. labels Jul 28, 2022
@DerLinkman
Copy link
Member

Would like to merge this inside the BS5 Branch. @FreddleSpl0it there is a change (a very small one :D) for the general BS with that patch.

That is the main reason why i would like to implement this directly to BS5 instead of BS3. So we skip a port so to say.

@DerLinkman DerLinkman changed the base branch from staging to feature/bootstrap5 September 27, 2022 13:42
@DerLinkman DerLinkman changed the base branch from feature/bootstrap5 to staging January 9, 2023 09:53
@feldsam feldsam force-pushed the feldsam/enhancements branch 2 times, most recently from f8dddbd to b51ce45 Compare March 18, 2023 15:24
@feldsam
Copy link
Member Author

feldsam commented Mar 18, 2023

Hi @DerLinkman, I just updated this PR to match latest staging branch.

Signed-off-by: Kristian Feldsam <feldsam@gmail.com>
@feldsam
Copy link
Member Author

feldsam commented Aug 31, 2023

Hi @DerLinkman, what about this PR?

@feldsam
Copy link
Member Author

feldsam commented Sep 2, 2023

PR is approved, so I am closing this and pushing directly to staging

@feldsam feldsam closed this Sep 2, 2023
@feldsam
Copy link
Member Author

feldsam commented Sep 2, 2023

ah, looks like my permission to commit to this project was removed :(

@feldsam feldsam reopened this Sep 2, 2023
@feldsam feldsam changed the title [web] apple config app passwords enhancements + translations [Web] apple config app passwords enhancements + translations Sep 3, 2023
@FreddleSpl0it FreddleSpl0it merged commit c64fdf9 into mailcow:staging Sep 8, 2023
4 checks passed
@feldsam feldsam deleted the feldsam/enhancements branch November 3, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants