Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Simplified Chinese Translation #4860

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Conversation

yhdsl
Copy link
Contributor

@yhdsl yhdsl commented Nov 14, 2022

I have made a complete update of the Chinese Translation, in summary, i have completed the translation and proofreading of all the translation, the complete fix text will be attached later.

I've read the translation guide on this site, as well as read this #4657 notes on Chinese Translation, and verified it inside a self-deployed Docker container.

The complete revision includes:

  • Ensure that all entries are covered (previously untranslated entries and translations that have become obsolete due to text changes)
  • Unified translation style (I made some adjustments for Chinese pages and reading habits)
  • Adjusted the grammar of some translations, such as placing the verb first instead of last
  • Go through all the translations and fix multiple typos and incorrectly used HTML tags (that are no longer used in the English entry) in conjunction with the UI
  • Adjust the order of the entries to make sure they match the English entries (I think this will look easier :D)

I hope this will be helpful

@milkmaker
Copy link
Collaborator

Thanks for contributing!

I noticed that you didn't select staging as your base branch. Please change the base branch to staging.
See the attached picture on how to change the base branch to staging:

check_prs_if_on_staging.png

@yhdsl yhdsl changed the base branch from master to staging November 14, 2022 13:44
@MAGICCC
Copy link
Member

MAGICCC commented Nov 14, 2022

Looks fine for me, can't speak chinese but didnt spot any json issues.
Next time you can use https://translate.mailcow.email/engage/mailcow-dockerized/ for translating

@DerLinkman DerLinkman added this to the 2022-11 milestone Nov 16, 2022
@yhdsl yhdsl closed this Nov 23, 2022
@MAGICCC
Copy link
Member

MAGICCC commented Nov 23, 2022

May I ask why you closed this PR @yhdsl?

@yhdsl yhdsl reopened this Nov 24, 2022
@yhdsl
Copy link
Contributor Author

yhdsl commented Nov 24, 2022

I got confused about the meaning of the button, due to I am not familiar with the operation of github

I hope I didn't screw anything up @MAGICCC

@MAGICCC
Copy link
Member

MAGICCC commented Nov 24, 2022

Hah it's ok, don't worry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants