[Postfix] fix extra.cf updating #5372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't |
|
@sriccio yeah, I agree that the Current method was introduced in this commit back in the end of 2020, I don't know why it was done in that way. I didn't change the current behaviour, just fixed the issue it has. |
|
same error here, please change it to work like mentioned in https://docs.mailcow.email/de/manual-guides/Postfix/u_e-postfix-extra_cf/ Thx! 🤞 |
DerLinkman
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to extend the postfix configuration by adding custom directives to extra.cf, and found out that some of them were disappearing on postfix-mailcow restarts. Specifically, this line:
smtpd_banner = $myhostname ESMTP PostfixSame problem is described here.
That happens due to untied
/myhostname/dsed operation indata/Dockerfiles/postfix/postfix.sh- it deletes not only themyhostname = example.orgline before updating it, but also lines like mentioned above.This PR fixes the issue by ignoring lines that contain
$myhostname(variable, not a directive) when cleaning up theextra.cf.