Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config for nginx >=1.25.1 (http2, server_names_hash_max_size, server_names_hash_bucket_size) #5383

Merged
merged 3 commits into from
Aug 29, 2023

Conversation

Dexus
Copy link
Contributor

@Dexus Dexus commented Aug 12, 2023

this patch removes the the deprecated warning about the http2 option on listen.
Also it prevents the log spamming could not build optimal server_names_hash, you should increase either server_names_hash_max_size: 512 or server_names_hash_bucket_size: 64; ignoring server_names_hash_bucket_size

@milkmaker
Copy link
Collaborator

Thanks for contributing!

I noticed that you didn't select staging as your base branch. Please change the base branch to staging.
See the attached picture on how to change the base branch to staging:

check_prs_if_on_staging.png

@Dexus Dexus changed the base branch from master to staging August 12, 2023 15:04
@FreddleSpl0it FreddleSpl0it merged commit 372b1c7 into mailcow:staging Aug 29, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants