Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for git < 2.7 #5459

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Fix for git < 2.7 #5459

merged 3 commits into from
Oct 30, 2023

Conversation

SecT0uch
Copy link
Contributor

@SecT0uch SecT0uch commented Oct 12, 2023

This change should be compatible with all git version. (get-url available from git 2.7)

DerLinkman and others added 3 commits October 12, 2023 12:55
This change should be compatible with all git version.
(get-url available from v1.7.5)
@milkmaker
Copy link
Collaborator

Thanks for contributing!

I noticed that you didn't select staging as your base branch. Please change the base branch to staging.
See the attached picture on how to change the base branch to staging:

check_prs_if_on_staging.png

@SecT0uch SecT0uch changed the base branch from master to staging October 12, 2023 13:59
@SecT0uch SecT0uch changed the title Fix for git < v1.7.5 Fix for git < 2.7 Oct 17, 2023
@DerLinkman
Copy link
Member

Does it work on other systems which are not using an old Git Version?

This needs to be 100% bulletproof otherwise it won't merged!

@SecT0uch
Copy link
Contributor Author

@DerLinkman yes it is:

$ git --version
git version 2.42.0
$ git config --get remote.origin.url
git@gitlab.com:fdroid/fdroidserver.git
$

@SecT0uch
Copy link
Contributor Author

SecT0uch commented Oct 30, 2023

@DerLinkman Any chance we can get that merged ?

Centos 7 users are having issues when running the update script.
The version I committed is way more bulletproof than get-url which has been added later on

@DerLinkman
Copy link
Member

Ah yes. Sorry I missed the merge. Yes that works! Thanks

@DerLinkman DerLinkman merged commit d5a2c96 into mailcow:staging Oct 30, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants