Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Postfix] Do not remove X-Mailer header #5504

Merged

Conversation

feldsam
Copy link
Member

@feldsam feldsam commented Oct 30, 2023

some providers, like seznam.cz use X-Mailer in DKIM signatures

Fixes #5335

@feldsam feldsam changed the base branch from master to staging October 30, 2023 00:26
@milkmaker
Copy link
Collaborator

Thanks for contributing!

I noticed that you didn't select staging as your base branch. Please change the base branch to staging.
See the attached picture on how to change the base branch to staging:

check_prs_if_on_staging.png

@feldsam feldsam changed the title Feldsam/do not remove x mailer fixes #5335 [Postfix] Do not remove X-Mailer header fixes #5335 Oct 30, 2023
@feldsam feldsam changed the title [Postfix] Do not remove X-Mailer header fixes #5335 [Postfix] Do not remove X-Mailer header Oct 30, 2023
@FreddleSpl0it
Copy link
Collaborator

@feldsam can you just comment out the X-Mailer line like

# Not removing Mailer by default, might be signed
#/^\s*X-Mailer/          IGNORE

some providers, like seznam.cz use X-Mailer in DKIM signatures

Signed-off-by: Kristian Feldsam <feldsam@gmail.com>
@feldsam feldsam force-pushed the feldsam/do-not-remove-x-mailer branch from 6329156 to 100e8ab Compare December 27, 2023 15:32
@feldsam
Copy link
Member Author

feldsam commented Dec 27, 2023

Hi @FreddleSpl0it , done

@FreddleSpl0it FreddleSpl0it merged commit acf9d54 into mailcow:staging Dec 27, 2023
@feldsam feldsam deleted the feldsam/do-not-remove-x-mailer branch December 28, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants