Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --dry IMAPsync Parameter as Button to select for SyncJobs #5521

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

raph-topo
Copy link
Contributor

Without this, setting Edit sync job > Custom parameters > --dry fails with:
image
(Even though --dry is a placeholder suggestion)

@MAGICCC
Copy link
Member

MAGICCC commented Nov 10, 2023

I guess we can also allow --releasecheck @DerLinkman

@raph-topo
Copy link
Contributor Author

raph-topo commented Nov 13, 2023

I also added the very useful --f1f2 in my instance, what do you think about that?

@DerLinkman
Copy link
Member

I guess we can also allow --releasecheck @DerLinkman

Nah that is not necessarily i think.

@DerLinkman
Copy link
Member

DerLinkman commented Nov 15, 2023

--dry is not a problem. That dry option might make more sense as a clickable selection button in my eyes though.

@DerLinkman
Copy link
Member

Tested it and it works but don't trust my php skills here. @FreddleSpl0it can you take a look at this whole thing?

@DerLinkman DerLinkman changed the title Allow --dry IMAPsync Add --dry IMAPsync Parameter als Button to select for SyncJobs Nov 15, 2023
@DerLinkman DerLinkman changed the title Add --dry IMAPsync Parameter als Button to select for SyncJobs Add --dry IMAPsync Parameter as Button to select for SyncJobs Nov 15, 2023
@DerLinkman
Copy link
Member

DerLinkman commented Nov 15, 2023

Looks like this now:

image

(Enabled for the Screenshot, disabled per default)

@DerLinkman
Copy link
Member

Btw, don't see a problem why --f1f2 should not be allowed.

@DerLinkman DerLinkman merged commit c8bee57 into mailcow:staging Nov 16, 2023
@raph-topo
Copy link
Contributor Author

Thank you for having accepted and improved this!

@raph-topo raph-topo deleted the fix/impasync-options branch November 16, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants