Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Netfilter] set IP check more relaxed on NFTables.py #5711

Merged
merged 5 commits into from Feb 8, 2024

Conversation

amorfo77
Copy link
Contributor

@amorfo77 amorfo77 commented Feb 7, 2024

issue #5709

docs:
If strict is True and host bits are set in the supplied address, then [ValueError](https://docs.python.org/dev/library/exceptions.html#ValueError) is raised. Otherwise, the host bits are masked out to determine the appropriate network address.

and edit typpo in #5628

@amorfo77 amorfo77 changed the title [Netfilter] set IP check strict to False [Netfilter] set IP check more relaxed on NFTables.py Feb 7, 2024
@DerLinkman DerLinkman merged commit 1926625 into mailcow:staging Feb 8, 2024
2 checks passed
@DerLinkman
Copy link
Member

Merci!

@ohobby
Copy link

ohobby commented Feb 8, 2024

Hi, i have run the update 2024-01e, but the netfilter container still restart again and again.
Is it wrong that the mailcow is in the ip input table? Is something else, what i can do?

netfilter-mailcow-1 | MAILCOW target is in position 2 in the ip input table, restarting container to fix it...
netfilter-mailcow-1 exited with code 2
netfilter-mailcow-1 | # Warning: table ip nat is managed by iptables-nft, do not touch!
netfilter-mailcow-1 | # Warning: table ip filter is managed by iptables-nft, do not touch!
netfilter-mailcow-1 | # Warning: table ip6 nat is managed by iptables-nft, do not touch!
netfilter-mailcow-1 | # Warning: table ip6 filter is managed by iptables-nft, do not touch!
netfilter-mailcow-1 | Using NFTables backend
netfilter-mailcow-1 | Clearing all bans
netfilter-mailcow-1 | Clear completed: ip
netfilter-mailcow-1 | Clear completed: ip6
netfilter-mailcow-1 | Initializing mailcow netfilter chain
netfilter-mailcow-1 | MAILCOW ip chain created successfully.
netfilter-mailcow-1 | MAILCOW ip6 chain created successfully.
netfilter-mailcow-1 | Setting MAILCOW isolation
netfilter-mailcow-1 | Watching Redis channel F2B_CHANNEL
netfilter-mailcow-1 | Blacklist was changed, it has 6 entries

@DerLinkman
Copy link
Member

Did you tried restarting your server?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants