New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add switch to skip fetching certificates auto{config,discover} subdomains #5838
base: staging
Are you sure you want to change the base?
Conversation
(Offtopic: How much I hate that the webinterface does sign my commits with a key I don't control. I'd rather they were unsigned. Sheesh.) |
You feel that variable definitely is too long?
|
that sounds kinda ambiguous but I'll put it if it gets it merged 😁 |
default on, default is fetching certs for auto{discover,conf}
also flipped
flipped default meaning
Sounds good to me, also thanks y'all for following up on it. |
and flipped meaning of the bool
Ok now after snail fast editing of things on my phone the name is changed, default flipped. |
Well now it looks cleaner for me, thanks. |
Just in case, I couldn't squash the commits together with the webinterface from the phone. I have no laptop nearby. But you'll merge squashed anyways ig? |
Can I get a yes or no here? |
Add switch to skip fetching certs for auto{config,discover} subdomains.
Might be useful in certain reverse proxy situations.
This is a cleaned up version of #5474
The things discussed there are changed and I made a better name.
I had to open a new PR due to Github Web UI limitations.
The old PR that is linked can bre closed.
@jennypaxian, pinging you too because you'll not be auto notified.