Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add switch to skip fetching certificates auto{config,discover} subdomains #5838

Open
wants to merge 13 commits into
base: staging
Choose a base branch
from

Conversation

schichtnudelauflauf
Copy link

Add switch to skip fetching certs for auto{config,discover} subdomains.

Might be useful in certain reverse proxy situations.

This is a cleaned up version of #5474

The things discussed there are changed and I made a better name.
I had to open a new PR due to Github Web UI limitations.

The old PR that is linked can bre closed.

@jennypaxian, pinging you too because you'll not be auto notified.

@schichtnudelauflauf
Copy link
Author

(Offtopic: How much I hate that the webinterface does sign my commits with a key I don't control. I'd rather they were unsigned. Sheesh.)

@dragoangel
Copy link
Collaborator

You feel that variable definitely is too long?

AUTODISCOVER_SAN=y/n and should be y by default in compose when unset. Don't want autodiscover, put it to n

@schichtnudelauflauf
Copy link
Author

that sounds kinda ambiguous but I'll put it if it gets it merged 😁

@jennypaxian
Copy link

You feel that variable definitely is too long?

AUTODISCOVER_SAN=y/n and should be y by default in compose when unset. Don't want autodiscover, put it to n

Sounds good to me, also thanks y'all for following up on it.

@schichtnudelauflauf
Copy link
Author

Ok now after snail fast editing of things on my phone the name is changed, default flipped.

@dragoangel
Copy link
Collaborator

Well now it looks cleaner for me, thanks.

@dragoangel dragoangel requested review from DerLinkman and FreddleSpl0it and removed request for DerLinkman April 10, 2024 07:20
@schichtnudelauflauf
Copy link
Author

Just in case, I couldn't squash the commits together with the webinterface from the phone. I have no laptop nearby. But you'll merge squashed anyways ig?

@schichtnudelauflauf
Copy link
Author

Can I get a yes or no here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants