Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update debug.twig to include a link to the git project URL for the mailcow version tag #5875

Open
wants to merge 5 commits into
base: staging
Choose a base branch
from

Conversation

CallMeLeon167
Copy link

This update adds a link to the Git project URL for the Mailcow version tag in the Debug Twig file. The link allows to quickly access the corresponding version of the project and gather more information.

Copy link

@Fighter456 Fighter456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target="_blanked" seems to be wrong.

@@ -77,7 +77,7 @@
<td>Version</td>
<td class="text-break">
<div class="fw-bolder">
<p ><a href="#" id="mailcow_version">{{ mailcow_info.version_tag }}</a></p>
<p ><a href="{{ mailcow_info.git_project_url }}/releases/tag/{{ mailcow_info.version_tag }}" id="mailcow_version" target="_blanked">{{ mailcow_info.version_tag }}</a></p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p ><a href="{{ mailcow_info.git_project_url }}/releases/tag/{{ mailcow_info.version_tag }}" id="mailcow_version" target="_blanked">{{ mailcow_info.version_tag }}</a></p>
<p><a href="{{ mailcow_info.git_project_url }}/releases/tag/{{ mailcow_info.version_tag }}" id="mailcow_version" target="_blank">{{ mailcow_info.version_tag }}</a></p>

@Fighter456
Copy link

The space within the <p>-opening element is superfluous. Can you fix it too?

Copy link

@Fighter456 Fighter456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

(Approval not possible due to repo-restrictions.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants