Switch IP2Country lookup backend to shortened version #5886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves performance of mailcow#5880
|
Thanks for contributing! I noticed that you didn't select
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Since the mailcow project only uses the short country function to display the country flag of the source IP, the new backend https://dfdata.bella.network/country/<IP/Domain> can be used. The lookup has been significantly accelerated and has now dropped from 700ms to 100ms on average.
Repeated requests are cached so that the search time is now only a few milliseconds.
This should improve the lookup speed mentioned in #5880.
Best regards,
Thomas