Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default Dockerfile port from 80/25 #244

Closed
djfarrelly opened this issue Mar 19, 2019 · 1 comment · Fixed by #281
Closed

Change default Dockerfile port from 80/25 #244

djfarrelly opened this issue Mar 19, 2019 · 1 comment · Fixed by #281

Comments

@djfarrelly
Copy link
Member

Purpose

I think it would better for Docker container security to not run the main command on a port under 1000.

Idea

Change the Dockerfile to run on 1080 / 1025 instead of 80 / 25. The challenge is that this could break people's usage when upgrading so we'd have to think about this one or save it for a 2.x breaking changes release.

@bearcodi
Copy link

bearcodi commented Nov 4, 2019

Hi @djfarrelly I've created a pull request for this, I kept getting errors when using the docker image on Mac when I was trying to bind to port 25

The pull request sets the default ports for web and smtp to 1080 and 1024 respectively.

Thanks for the cool project! Its in my dev/test toolkit by default!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants