Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emails with <base> break embedded images #97

Closed
Arcnor opened this issue Nov 30, 2015 · 2 comments
Closed

Emails with <base> break embedded images #97

Arcnor opened this issue Nov 30, 2015 · 2 comments

Comments

@Arcnor
Copy link

Arcnor commented Nov 30, 2015

Related to #69 , if the email contains a tag on its head, the images will not show. For example:

<html>
<head><base href="http://example.com"/></head>
<body>
<img src="/email/cGVlFdin/attachment/myImage.png"/>
</body>
</html>

That's the HTML generated by MailDev, which looks correct, except that the image will be accessed at "http://example.com/email/cGVlFdin/attachment/myImage.png" instead of "http://localhost:1080/email/cGVlFdin/attachment/myImage.png"
@djfarrelly djfarrelly added the bug label Dec 2, 2015
@soullivaneuh
Copy link
Contributor

@Arcnor Just for curiosity, does the base tag work on every email platform?

@Arcnor
Copy link
Author

Arcnor commented Jan 19, 2016

AFAIK it does, we've been using it for a long time now.
On Jan 20, 2016 12:31 AM, "Sullivan SENECHAL" notifications@github.com
wrote:

@Arcnor https://github.com/Arcnor Just for curiosity, does the base tag
work on every email platform?

—
Reply to this email directly or view it on GitHub
#97 (comment).

djfarrelly added a commit that referenced this issue Mar 20, 2016
@djfarrelly
Pass base url for absolute attachment urls. Fixes #97
589c2da
@djfarrelly djfarrelly removed the bug label Mar 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Arcnor @djfarrelly @soullivaneuh