Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker verbose option #103

Closed
wants to merge 1 commit into from

Conversation

soullivaneuh
Copy link
Contributor

Here is a PoC as suggested on #100 (comment).

I just added verbose options but we can add more.

But I agree that having a maildev.json configuration file (#93) would be easier. With that, we will just have to link our config file to the docker container.

@soullivaneuh
Copy link
Contributor Author

Another possibility: Let user set a OPTS env var that will be added to the default (web and smtp options should not be changed on docker due to exposed ports).

What do you think?

@djfarrelly
Copy link
Member

For this PR, I do think my feelings are still the same as this comment, but your point about using an OPTS or similar environment variable for additional args could be a cool point to meet halfway! I wonder, could we use an environment variable in the CMD itself and skip the entrypoint.sh?

ENV OPTS=""
CMD ["sh", "-c", "bin/maildev --web 80 --smtp 25", "$OPTS"]

@soullivaneuh
Copy link
Contributor Author

Hi @djfarrelly, sorry for the delay.

I think your method is less reliable about option description, but we could do that.

Do you want me to update this PR accordingly to your demand?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants