Better shutdown handling #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close all open connection sockets when the server is shut down. Some connections are kept open with the keep-alive header or via websockets. This allows us to quickly shutdown the server. More info: nodejs/node#2642
This will be easier to maintain and also upgrades Node.js while keeping the size similar.
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
==========================================
- Coverage 60.72% 57.47% -3.25%
==========================================
Files 7 7
Lines 499 515 +16
Branches 106 106
==========================================
- Hits 303 296 -7
- Misses 196 219 +23
Continue to review full report at Codecov.
|
|
Merged PR despite build failure - Planning to drop support of Node 0.10 and 0.12 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Originally intended to fix #156 after testing #157 and it wasn't working during my local debugging. This now handles and destroys all open socket connections which makes the web server shut down immediately.
Notes
This also has other improvements around the Docker image and some items that I should have fixed long ago.
More insight into the connection handling here: nodejs/node#2642
Review
Hey @jsonxr and @donut87, this should fix #156 up! Would love to see if you had any comments or feedback for this!