-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a way of limiting the mail storage size #237
base: master
Are you sure you want to change the base?
Conversation
c997337
to
370a913
Compare
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
=========================================
Coverage ? 65.37%
=========================================
Files ? 9
Lines ? 517
Branches ? 109
=========================================
Hits ? 338
Misses ? 179
Partials ? 0
Continue to review full report at Codecov.
|
370a913
to
2f4922f
Compare
MailDev may sometimes be used as a part of a development/staging environment where the process may be running for a very long time without interruption. In those cases, it is undesirable to let that process grow freely. This limit makes sure that the memory usage is bounded.
2f4922f
to
3d13ec9
Compare
This is a great feature, and I am looking forward to using it. Thank you for including a test. Here's what I'd like to see before pulling:
|
Good points! Fixed!
I did find some flaws in the test, so I have redone it now. Take a look at it and let me know you see any more issues there. |
Also, as you can see in the test, I had to clear the store, because it contained leftovers from the previous test cases. We should probably empty the store every time a new EmailServer is created (under the assumption that there should be max one running instance of it)? |
@kgeis Do you think we could this merged in sometime soon? |
MailDev may sometimes be used as a part of a development/staging environment where the process may be running for a very long time without interruption. In those cases, it is undesirable to let that
process grow freely. This limit makes sure that the memory usage is bounded.