Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appveyor configuration #247

Merged
merged 1 commit into from Mar 23, 2019
Merged

Add appveyor configuration #247

merged 1 commit into from Mar 23, 2019

Conversation

oktapodia
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #247 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #247   +/-   ##
=======================================
  Coverage   71.51%   71.51%           
=======================================
  Files           9        9           
  Lines         509      509           
  Branches      106      106           
=======================================
  Hits          364      364           
  Misses        145      145

@kgeis
Copy link
Collaborator

kgeis commented Mar 22, 2019

@oktapodia, I don't understand what issue this resolves. Do you want to use Appveyor instead of Travis or in addition? What is the reason?

@oktapodia
Copy link
Contributor Author

@kgeis only in addition of Travis, I read many issues saying that we have a bug on windows, appveyor is running the tests on a windows machine and will help us to directly spot the introduced bug on windows :)

Copy link
Collaborator

@kgeis kgeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the intent of this change and am neutral on it technically because I don't know appveyor. I checked that the Node.js versions match what is being tested in Travis.

@oktapodia oktapodia merged commit 5ba1e01 into master Mar 23, 2019
@oktapodia oktapodia deleted the feature/add-appveyor branch March 23, 2019 04:03
Copy link
Member

@djfarrelly djfarrelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants