Implemented Healthcheck based on existing health endpoint in Dockerfi… #265
Conversation
Codecov Report
@@ Coverage Diff @@
## master #265 +/- ##
=======================================
Coverage 71.65% 71.65%
=======================================
Files 9 9
Lines 515 515
Branches 107 107
=======================================
Hits 369 369
Misses 146 146 |
.gitignore
Outdated
| @@ -12,3 +12,4 @@ settings.json | |||
|
|
|||
| # Ignore npm debug log | |||
| npm-debug.log | |||
| .idea | |||
There was a problem hiding this comment.
Can you please remove that? This is linked to your dev environment and should not be in the project
| .idea | |
| -.idea |
There was a problem hiding this comment.
Sure, however I would like to point that the gitignore already contains an entry Sublime Text (see line 10 in the gitignore).
Considering this I would suggest leaving the ignore for the .idea directory in the file, it does'nt cause any harm but prevents someone from accidentally committing their IntelliJ / Webstorm IDE settings
There was a problem hiding this comment.
Good catch! Feel free to remove the sublime text as well :)
There was a problem hiding this comment.
:)
Ok, I removed both lines
Dockerfile
Outdated
| @@ -3,6 +3,9 @@ MAINTAINER "Dan Farrelly <daniel.j.farrelly@gmail.com>" | |||
|
|
|||
| ENV NODE_ENV production | |||
|
|
|||
| RUN apk add --no-cache curl && \ | |||
There was a problem hiding this comment.
The --no-cache should be enough, can you please remove the rm?
There was a problem hiding this comment.
I changed this as suggested
pgerhard
force-pushed
the
DockerHealthEndpoint
branch
from
68a960c
to
9280842
Compare
…le. Removed sublime specific value from gitignore
pgerhard
force-pushed
the
DockerHealthEndpoint
branch
from
9280842
to
02c9ecc
Compare
|
Thank you! That will be included soon in the production release. |
Pull request for #264