Add a toggle to display menus wide #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micoli
force-pushed
the
toggle-to-display-menu-wide
branch
from
37842d3
to
b0e0ada
Compare
Codecov Report
@@ Coverage Diff @@
## master #268 +/- ##
=======================================
Coverage 71.65% 71.65%
=======================================
Files 9 9
Lines 515 515
Branches 107 107
=======================================
Hits 369 369
Misses 146 146 |
oktapodia
reviewed
Oct 18, 2019
oktapodia
requested changes
Oct 18, 2019
A toggle is displayed at the upper right corner, when triggered display menu are eitehr displayed as dropdown menu, or like a toolbar
micoli
force-pushed
the
toggle-to-display-menu-wide
branch
from
b0e0ada
to
a9b64a1
Compare
Codecov Report
@@ Coverage Diff @@
## master #268 +/- ##
=======================================
Coverage 71.65% 71.65%
=======================================
Files 9 9
Lines 515 515
Branches 107 107
=======================================
Hits 369 369
Misses 146 146 |
|
After adding the new toggle design in #291, I moved the setting toggle there which now also supports persisting in local storage
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A toggle is displayed at the upper right corner, when triggered
display menu are either displayed as dropdown menu, or like a
toolbar