chore: bring projects back to life #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd update nodemailer v6
- Declare a new CLI option, `--log-mail-contents`; when specified, maildev will log the JSON representation of each incoming mail, equivalent to the payloads emitted for 'new' events - Implement the logging of mail contents by adding a listener for 'new' events emitted by mailserver, and logging the events - Add relevant documentation in README Port of opengovsg/maildev@c483402
feat: enable logging of mail contents via CLI option
…on to es6 to comply with code specifications and avoid test errors with node v14
soulteary
force-pushed
the
feedback-upstream
branch
from
b582cf7
to
b10a551
Compare
…date deps from npmjs.org
soulteary
force-pushed
the
feedback-upstream
branch
from
2c346ee
to
70c17ab
Compare
This was referenced Mar 22, 2022
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #379
contains:
code dependency upgrades, security fixes, please refer to the commit record title for details.
add cli option: feat: enable logging of mail contents via CLI option , thanks @LoneRifle
Although it seems to be functional so far, there are unexpected issues due to some dependencies and older Node LTS for testing, eg:
Therefore, it is not recommended to directly merge functions for the time being, and some work is needed to correct the problems detected by the test.