Connection close and relay #87
Conversation
look for email addresses in `envelope.from` and `envelope.to` if the `.address` is undefined. closes maildev#86.
|
Works for me, thanks a lot! |
Since the connection needs to be closed (quit), we need to reconfigure the smtp connection.
also inserted it. Sorry for multiple commits I am new to 'npm test'
|
Hi @donut87! I've pulled this down and have done a bunch of testing and when using Gmail, this will work on the first relay, but will fail on any any future relays. It seems the reconnection needed to be changed to
Edit: I'd love to know more about the SMTP error you were seeing as there might be some other things I could improve about the outgoing SMTP connection! Thanks 😉 |
|
@djfarrelly I've started this in #86, maybe the description there helps? |
|
Ah ok, thanks @diresi - With the timeout issue I'm thinking a better flow for maildev might be |
Hi,
these two commits allow us to relay incoming mails. diresis commit ensures, that there is no "null" recipient or sender and the other commit closes the smtp connection after sending an email. This was necessary because we always got an error when the connection was closed by the smtp server.
Cheers
Christian